ATO-218 Always set slot values #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
ab526b3 to
f6e87a7
Compare
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
f6e87a7 to
f377154
Compare
sanchariGr
approved these changes
Jul 14, 2022
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
f377154 to
8491f55
Compare
losterloh
requested review from
dakshvar22 and
aerowithanl
and removed request for
a team
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
8491f55 to
d2948f0
Compare
|
done @sanchariGr , see current changes - CI should hopefully run green now. |
indam23
suggested changes
Jul 14, 2022
indam23
approved these changes
Jul 14, 2022
ancalita
reviewed
Jul 14, 2022
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
eb6805d to
262a312
Compare
This fixes a bug where slot values vanish when using the augmented memoization policy. If in the past, the slot is set to a specific value, and then later the slot being set to the same value, no new SlotSet event is emitted. However, this leads to the augmented memoiziation policy wrongly assuming this slot to be unset, as the older, original SlotSet event was pruned already.
losterloh
force-pushed
the
ATO-218-always-set-slots
branch
from
a584cc4 to
88fe676
Compare
ancalita
approved these changes
Jul 14, 2022
|
@ancalita The purpose of the |
|
@ancalita reducing the epochs to 10 is actually breaking the test 😬 So I won't do that after all. |
No worries, yeah there's a sweet spot with these epochs, if you go below a level it just breaks. |
sanchariGr
force-pushed
the
ATO-218-always-set-slots
branch
from
88fe676 to
0e74c32
Compare
sanchariGr
force-pushed
the
ATO-218-always-set-slots
branch
from
0e74c32 to
66343c9
Compare
|
🚀 A preview of the docs have been deployed at the following URL: https://11333--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
indam23
pushed a commit
that referenced
this pull request
Jul 18, 2022
ATO-218 Always set slot values
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where slot values vanish when using the augmented
memoization policy. If in the past, the slot is set to a specific value,
and then later the slot being set to the same value, no new SlotSet
event is emitted. However, this leads to the augmented memoiziation
policy wrongly assuming this slot to be unset, as the older, original
SlotSet event was pruned already.
Status (please check what you already did):
black(please check Readme for instructions)