-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATO 207 run form validation on form activation #11326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, an additional q I have is to double-check there was no need to add this check back into _get_slot_extractions
for loop which was removed in PR 10295?
if not tracker.active_loop:
break
Looked into this, but it doesn't seem to make any difference whether the check is there or not; all forms tests pass either way 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoop whoop 🎉
Left one tiny comment to make sure we have that wondering assert back into test_activate
too, otherwise good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
🚀 A preview of the docs have been deployed at the following URL: https://11326--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Can we merge and release this soon? thanks. |
Proposed changes:
active_loop
is set yet #10913 obsolete since the 2.x mechanism for achieving the same thing would be returned.extract_<slot_name>
method in a FormValidationAction subclass only runs after a required_slot in the form has been set (i.e. after activation).Status (please check what you already did):
black
(please check Readme for instructions)