-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack channel fixes #11305
Slack channel fixes #11305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maxinho96 Thank you for your contribution 🙌🏻
Looks great 💯 Before I approve this PR, I would like you to:
- add a unit test that fails when you revert your changes and passes with your fixes (the unit test should be placed under
tests/core/channels/test_slack.py
) - add a changelog entry in the changelog directory, you can use the PR id as changelog entry ID, please use type
bugfix
.
Also please note that since your PR is targeting main
, this change won't be released until the next minor and that is tentatively scheduled towards the end of Q3. Alternatively, you can recreate your PR to target 3.2.x
and we can release a micro much earlier.
@ancalita done :) |
@Maxinho96 To double-check did you also rebase your branch locally and then forced push? It seems the PR now contains a lot of extra commits 😬 This will have to be fixed before I can review again. |
@ancalita Sorry, I have fixed with a rebase :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the speedy implementations, looks great 💯
I just have two more suggestions for expanding a bit on the issue and solution in the changelog entry & for refactoring a bit the tests. Let me know how you get on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)