make action server connection error message more descriptive #11123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losterloh
approved these changes
May 16, 2022
| @@ -548,7 +548,7 @@ async def test_remote_action_endpoint_not_running( | |||
|
|
|||
| with pytest.raises(Exception) as execinfo: | |||
| await remote_action.run(default_channel, default_nlg, default_tracker, domain) | |||
| assert "Failed to execute custom action." in str(execinfo.value) | |||
| assert "Failed to execute custom action" in str(execinfo.value) | |||
There was a problem hiding this comment.
Why are we now omitting the final period .? Do we have a policy for formatting log messages?
There was a problem hiding this comment.
Omitting here because in the messages the test checks, it is now followed by other words - it's no longer a standalone sentence. Otherwise log messages should end with a period.
|
🚀 A preview of the docs have been deployed at the following URL: https://11123--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
indam23
deleted the
ATO-90-make-exception-for-unreachable-action-server-descriptive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)