Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multidomain with entities with roles #10767

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Fix multidomain with entities with roles #10767

merged 6 commits into from
Jan 31, 2022

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Jan 28, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 requested a review from a team as a code owner January 28, 2022 09:42
@indam23 indam23 requested review from a team, carlad and JEM-Mosig and removed request for a team January 28, 2022 09:42
@indam23 indam23 changed the base branch from main to 3.0.x January 28, 2022 09:42
@indam23 indam23 removed the request for review from JEM-Mosig January 28, 2022 09:42
@indam23 indam23 mentioned this pull request Jan 28, 2022
Merged
3 tasks
@carlad
Copy link
Contributor

carlad commented Jan 28, 2022

Hey @melindaloubser1 looks good, thanks for fixing this.
Is it worth updating this test so that it includes some entities with roles as described in #10766 ?
The domain this test uses lives in data/test_domains/test_domain_from_multiple_files/

@indam23
Copy link
Contributor Author

indam23 commented Jan 28, 2022

Yep for sure, was just busy updating it 🙃

@indam23 indam23 force-pushed the fix_multidomain_entity_roles branch from 6024955 to be2ae5e Compare January 28, 2022 10:36
@indam23 indam23 requested a review from a team as a code owner January 28, 2022 10:36
@indam23 indam23 requested review from virtualroot and removed request for a team January 28, 2022 10:36
@indam23 indam23 changed the base branch from 3.0.x to main January 28, 2022 10:44
@indam23 indam23 removed the request for review from virtualroot January 28, 2022 10:45
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://10767--rasahq-docs-rasa-v2.netlify.app/docs/rasa

indam23 added a commit that referenced this pull request Jan 31, 2022
@indam23
Merge pull request #10768 from RasaHQ/fix_multidomain_entity_roles_2.8
e162973 
Fix multidomain with entities with roles  - backport of #10767 for 2.8.x
@indam23 indam23 merged commit 1e21478 into main Jan 31, 2022
@indam23 indam23 deleted the fix_multidomain_entity_roles branch January 31, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlad carlad carlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use multiple domains with entity roles or groups
2 participants
@indam23 @carlad