Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prompt_toolkit ^2.0 #10761

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Use prompt_toolkit ^2.0 #10761

merged 4 commits into from
Jan 28, 2022

Conversation

carlad
Copy link
Contributor

@carlad carlad commented Jan 27, 2022 •
edited
Loading

Proposed changes:

  • addresses ongoing issue in rasa-sdk #592
  • rasa-sdk has had similar dependency applied and new 3.0.4 version released

@carlad carlad changed the title WIP: tie prompt toolkit to 2.0.10 Use prompt_toolkit ^2.0 Jan 27, 2022
@carlad carlad requested a review from vpol January 27, 2022 17:37
@carlad carlad enabled auto-merge (squash) January 27, 2022 17:38
@carlad carlad requested a review from ancalita January 28, 2022 09:27
ancalita
ancalita approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@carlad carlad merged commit 43a1102 into 3.0.x Jan 28, 2022
@carlad carlad deleted the 592-prompt-toolkit-2.0.10 branch January 28, 2022 10:45
carlad added a commit that referenced this pull request Jan 28, 2022
@carlad
Use prompt_toolkit ^2.0 (#10761)
ed929c9 
* use prompt-toolkit ^2.0
* use rasa-sdk 3.0.4
carlad added a commit that referenced this pull request Feb 1, 2022
@rasabot @jupyterjazz
@carlad @ancalita @mleimeister
Merge 3.0.x into main (#10777)
b1f43cc 
* Update dependencies in 3.0 to align with rasa-sdk (#10667
* bump rasa-sdk
* filtering messages during training/prediction draft
* remove unfeaturized messages for some nlu components
* update forms docs with dynamic form example for removal of required slot
* Use tf.function for model prediction in RasaModel. (#10738)
* Use prompt_toolkit ^2.0 (#10761)

Co-authored-by: jupyterjazz <[email protected]>
Co-authored-by: carlad <[email protected]>
Co-authored-by: Anca Lita <[email protected]>
Co-authored-by: Matthias Leimeister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

@vpol vpol Awaiting requested review from vpol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlad @ancalita