Fix CI workflow runs using manually created virtual environments #10601
Conversation
m-vdb
force-pushed
the
fix-docs-workflow-run
branch
2 times, most recently
from
554b73f to
67057b4
Compare
m-vdb
force-pushed
the
fix-docs-workflow-run
branch
from
67057b4 to
45519aa
Compare
m-vdb
force-pushed
the
fix-docs-workflow-run
branch
from
ef09aa6 to
7717373
Compare
| key: ${{ runner.os }}-poetry-${{ env.POETRY_VERSION }}-${{ env.DEFAULT_PYTHON_VERSION }}-${{ hashFiles('**/poetry.lock') }}-${{ secrets.POETRY_CACHE_VERSION }} | ||
| restore-keys: ${{ runner.os }}-poetry-${{ env.DEFAULT_PYTHON_VERSION }} | ||
|
|
||
| - name: Clear Poetry cache | ||
| if: steps.cache-poetry.outputs.cache-hit == 'true' && contains(github.event.pull_request.labels.*.name, 'tools:clear-poetry-cache-docs-tests') |
There was a problem hiding this comment.
do we document PR labels like tools:clear-poetry-cache-docs-tests somewhere? I haven't created the label yet on github (same for other new labels introduced in this PR)
There was a problem hiding this comment.
This notion page is the closest I can find
There was a problem hiding this comment.
🤔 I guess I'll just create the labels in GitHub for now, and describe them here
m-vdb
changed the title
|
🚀 A preview of the docs have been deployed at the following URL: https://10601--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
|
|
||
| - name: Set up virtual environment | ||
| if: needs.changes.outputs.docs == 'true' | ||
| run: poetry config virtualenvs.in-project true |
There was a problem hiding this comment.
Is it correct to set this in-project option to True? As far as I can see, poetry will create a new virtualenv itself with this option and it will be overwritten by python -v venv create .venv later on I'm guessing? If not set -which is the default- it will use existing venv if available (which will exist after manual creation and if it had not existed I think poetry would be creating a new venv by default and this is handled by virtualenvs.create option).
There was a problem hiding this comment.
I think this is bypassing the creation of the venv in poetry somehow, because this is what failed before
If set to true, the virtualenv wil be created and expected in a folder named .venv within the root directory of the project.
In the case the .venv already exists (which we now enforce), I'm guessing poetry doesn't do anything (expected in a folder named .venv)
Proposed changes:
change_filters.ymlto also listen to changes in workflow filesStatus (please check what you already did):
black(please check Readme for instructions)