Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply #10137 domain merging changes to main #10570

Closed
carlad opened this issue Dec 22, 2021 · 0 comments · Fixed by #10589
Closed

Apply #10137 domain merging changes to main #10570

carlad opened this issue Dec 22, 2021 · 0 comments · Fixed by #10589
Assignees
@carlad
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-x/backend 🎩 All issues focused on the Rasa X backend type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@carlad
Copy link
Contributor

carlad commented Dec 22, 2021 •
edited
Loading

Rasa Open Source version

3.0

Rasa SDK version

No response

Rasa X version

No response

Python version

3.8

What operating system are you using?

OSX

What happened?

We need to apply the changes that fixed #10137 in this PR for 2.8.x to main.

We need to be aware that Domain logic in main likely differs to that of 2.8.x

One example is the additional method in the merge function on main:
https://github.com/RasaHQ/rasa/blob/main/rasa/shared/core/domain.py#L291

Command / Request

No response

Relevant log output

No response
@carlad carlad added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-x/backend 🎩 All issues focused on the Rasa X backend area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Dec 22, 2021
@carlad carlad changed the title Apply #10137 domain merging changes to 3.0.x Apply #10137 domain merging changes to main Dec 23, 2021
@carlad carlad mentioned this issue Dec 23, 2021
Merged
3 tasks
@carlad carlad self-assigned this Dec 27, 2021
@carlad carlad mentioned this issue Dec 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlad carlad

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-x/backend 🎩 All issues focused on the Rasa X backend type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add #10137 changes to domain merging RasaHQ/rasa
1 participant
@carlad