Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SSL Cert Parameters to Redis Tracker Store #10545

Merged
merged 15 commits into from
Feb 4, 2022
Merged

Added SSL Cert Parameters to Redis Tracker Store #10545

merged 15 commits into from
Feb 4, 2022

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Dec 16, 2021 •
edited
Loading

Proposed changes:

  • Added optional ssl_keyfile, ssl_certfile, and ssl_ca_certs parameters to the Redis tracker store.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran requested a review from a team as a code owner December 16, 2021 14:23
@b-quachtran b-quachtran requested review from alwx and removed request for a team December 16, 2021 14:23
@b-quachtran b-quachtran enabled auto-merge January 3, 2022 16:38
@b-quachtran b-quachtran requested review from a team, usc-m and joejuzl and removed request for alwx, jupyterjazz, a team and usc-m January 3, 2022 16:38
joejuzl
joejuzl reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@joejuzl joejuzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these parameters get automatically passed down from endpoints.yml and if so, can we test that it works?

@b-quachtran b-quachtran requested a review from joejuzl February 4, 2022 03:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

🚀 A preview of the docs have been deployed at the following URL: https://10545--rasahq-docs-rasa-v2.netlify.app/docs/rasa

joejuzl
joejuzl approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@joejuzl joejuzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@b-quachtran b-quachtran merged commit c07efa3 into main Feb 4, 2022
@b-quachtran b-quachtran deleted the redis-ssl-tracker branch February 4, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl joejuzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-quachtran @joejuzl @rasabot