Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num_threads and finetuning_epoch_fraction CLI defaults overwrite user config #10409

Closed
3 tasks
ka-bu opened this issue Nov 26, 2021 · 0 comments · Fixed by #10492
Closed
3 tasks

num_threads and finetuning_epoch_fraction CLI defaults overwrite user config #10409

ka-bu opened this issue Nov 26, 2021 · 0 comments · Fixed by #10492
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ka-bu
Copy link
Contributor

ka-bu commented Nov 26, 2021

Rasa Open Source version

3.0.0

Rasa SDK version

No response

Rasa X version

No response

Python version

3.8

What operating system are you using?

OSX

What happened?

In default_recipe.py, _extra_config_from_cli will always return something for the num_threads (and for the finetuning fraction, if we're in finetuning mode) (because otherwise the cli_parameter[param] call would fail). If the user does not specify any CLI parameters then that something are the default (CLI) parameters which will then overwrite the user settings:

To reproduce this, e.g. create a config with MITIE components and set the num_threads

pipeline:
- name: "MitieNLP"
  model: "<add-your-path-here>/total_word_feature_extractor.dat"
- name: "MitieTokenizer"
- name: "MitieFeaturizer"
- name: "MitieEntityExtractor"
- name: "MitieIntentClassifier"
  num_threads: 200000

and add a breakpoint to _add_nlu_train_mode

Command / Request

No response

Relevant log output

No response

Definition of done

  • Ensure that num_threads can be set
  • Determine a way to test this properly
  • Add a test
@ka-bu ka-bu added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Nov 26, 2021
@TyDunn TyDunn added priority:high effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
3 participants