changed the generator to load full tracker including all sessions + added markers changelog #10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeshky
changed the title
…h multiple sessions is correctly read.
… test function to fixture.
…markers_bugfix * 'markers_bugfix' of https://github.com/RasaHQ/rasa: Fix model dir (#10164) add changelog entry about tf2.6 update (#10153) conversation_granularity for slack - per user | per user per channel | per user per thread (#10086) add changelog fragment for docs changes in 3.0 fix syntax in training data example in the docs
- using tmp_path - using len() instead of hardcoded number of events.
|
Thanks both for a speedy review 🚀 |
ka-bu
reviewed
Nov 11, 2021
| @@ -20,6 +21,29 @@ def marker_trackerstore() -> TrackerStore: | |||
| return store | |||
|
|
|||
|
|
|||
| def test_load_sessions(tmp_path): | |||
There was a problem hiding this comment.
Suggested change
| def test_load_sessions(tmp_path): | |
| def test_load_sessions(tmp_path : Path): |
| def test_load_sessions(tmp_path): | ||
| """Tests loading a tracker with multiple sessions.""" | ||
| domain = Domain.empty() | ||
| store = SQLTrackerStore(domain, db=os.path.join(tmp_path, "temp.db")) |
There was a problem hiding this comment.
btw, with paths, you can also do things like
Suggested change
| store = SQLTrackerStore(domain, db=os.path.join(tmp_path, "temp.db")) | |
| store = SQLTrackerStore(domain, db= tmp_path / "temp.db") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
MarkerTrackerLoaderto load the full tracker usingretrieve_full_trackerinstead ofretrieve.Fixes The result of markers evaluations doesn't seem to detect/include markers in all cases #10124
Status (please check what you already did):
black(please check Readme for instructions)