Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook for filled orders #3

Open
nickjuntilla opened this issue Jul 28, 2021 · 9 comments
Open

Webhook for filled orders #3

nickjuntilla opened this issue Jul 28, 2021 · 9 comments
Assignees
Labels
protocol-enhancement New feature or request Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix)

Comments

@nickjuntilla
Copy link

We would like to alert our users when an NFT is sold. This way we could send them a congratulatory email or something of that nature. This could be possible by having a webhook callback parameter in the sell order.

@antho1404
Copy link

Currently, one workaround is to listen to to the event Match of the exchange smart contract end send an email or whatever job you need when the event is received.

That's not ideal as this requires your backend to maintain a connection to the blockchain but at least there is a way to do that.

@evgenynacu
Copy link
Member

One question: do you prefer to get a webhook for this or for example to use websocket for event streaming?

@antho1404
Copy link

Webhook would definitely be better as it can be connected to a stateless/serverless endpoint.
Websocket is interesting but maintaining an open connection is always tricky. I don't see much value in that, as it can already be done by directly listening to the events in the smart contract.

@nickjuntilla
Copy link
Author

I agree with @antho1404 we use stateless google cloud functions and the webhook is great.

@evgenynacu
Copy link
Member

Ok, thanks for the information @antho1404 @nickjuntilla

Also, if you have capacity to contribute, will guide you to how this can be implemented and what should be changed.
Let me know if you are ready to contribute

@antho1404
Copy link

Depending on the time required, I might be able to contribute to that.

@evgenynacu
Copy link
Member

@sanufriev could you guide @antho1404 and anyone interested what's needed to be done to add a webhook for order state change

@evgenynacu evgenynacu added the protocol-enhancement New feature or request label Oct 11, 2021
@antho1404
Copy link

This issue has been closed. What's the status? Is this something possible to do now? If so, how? Or is this something that will not be done because it can be done directly by listening to the chain?

@eduardstal
Copy link
Contributor

This issue has been closed. What's the status? Is this something possible to do now? If so, how? Or is this something that will not be done because it can be done directly by listening to the chain?

Hey Antho, I was under the mistaken idea that you were reached by @sanufriev already. Then this issue should not be closed, let me try to get ahold of him again to look over this issue.

@eduardstal eduardstal reopened this Nov 16, 2021
@eduardstal eduardstal added the Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix) label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol-enhancement New feature or request Tier 3 - in progress Tier three question: ETA for fix is 4-7 business days (requires contract changes / bug fix)
Projects
None yet
Development

No branches or pull requests

5 participants