Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(device): implements report device command #371

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

guptadev21
Copy link
Member

@guptadev21 guptadev21 commented Oct 17, 2024

  • Introduced a new feature to report a device using the CLI.
  • Added the rio device report DEVICE_NAME command to enable users to report the status of a specific device by its name.
  • Added -f, --force or --silent flags to skip confirmation prompts during device reporting.
  • Added --share, -s flag to generate a sharable URL for the device report.
  • Added --expiry, -e flag to set the expiry (in days) for the sharable URL. Default expiry is 7 days if not specified.
Usage: rio device report [OPTIONS] DEVICE_NAME

  Report a device and get its debug logs in uploads section.

Options:
  -f, --force, --silent  Skip confirmation
  -s, --share            Share the device logs with Rapyuta support
  -e, --expiry INTEGER   Expiry time for the shared URL in days  [default: 7]
  --help                 Show this message and exit.

Ticket ID: 19657

@guptadev21 guptadev21 requested review from a team as code owners October 17, 2024 12:36
Copy link

github-actions bot commented Oct 17, 2024

🤖 Pull Request Artifacts (#11403482471) 🎉

@pallabpain pallabpain changed the base branch from devel to chore/use-uv-pyproject October 18, 2024 05:47
@guptadev21 guptadev21 added the ✨ feature A new feature addition to the CLI label Oct 18, 2024
@pallabpain pallabpain changed the title Add report device feature in cli feat(device): implements report device command Oct 18, 2024
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, minor code improvements suggested.

Also, is it possible to print the Link to the uploaded debug logs as well? So that when the user is reporting, they can share it directly with us.

riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/util.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
@guptadev21 guptadev21 changed the base branch from chore/use-uv-pyproject to devel October 18, 2024 08:00
@guptadev21 guptadev21 changed the base branch from devel to chore/use-uv-pyproject October 18, 2024 08:01
@guptadev21 guptadev21 changed the base branch from chore/use-uv-pyproject to devel October 18, 2024 08:05
Copy link
Contributor

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.

riocli/device/util.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Outdated Show resolved Hide resolved
riocli/device/report.py Show resolved Hide resolved
riocli/device/report.py Show resolved Hide resolved
@pallabpain pallabpain merged commit acdde63 into devel Oct 18, 2024
11 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Oct 21, 2024
# [9.1.0](v9.0.4...v9.1.0) (2024-10-21)

### Bug Fixes

* **apply:** merge rio namespace with incoming values ([5141bcf](5141bcf))
* **package:** adds the missing --silent alias for force delete ([d4546a9](d4546a9))
* removes object references of project, static-routes, secret, deployment ([8cb381a](8cb381a))

### Features

* **apply:** allow mutiple values and secret files ([1cffe09](1cffe09)), closes [AB#18436](https://github.com/AB/issues/18436)
* **device:** implements report device command ([#371](#371)) ([acdde63](acdde63)), closes [AB#19657](https://github.com/AB/issues/19657)
* **device:** wait until virtual device is online on rapyuta.io ([f6bd3e8](f6bd3e8)), closes [AB#18043](https://github.com/AB/issues/18043)
* **secret:** implements batch delete with regex pattern ([9b57d69](9b57d69)), closes [AB#18146](https://github.com/AB/issues/18146)
* **static-route:** implements batch delete using regex pattern ([a3b5e92](a3b5e92)), closes [AB#18146](https://github.com/AB/issues/18146)
* **vpn:** adds option to populate vpn peers in hosts file ([c28b9ce](c28b9ce))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 9.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the feat/report-device branch December 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature A new feature addition to the CLI released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants