Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): inspect deployment with guid #349

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

YaswanthKumar-eng
Copy link
Contributor

This pr is for guid support for deployment resource inspection. So we can also see the manifest for deprovisioned/stopped deployments.

Copy link

github-actions bot commented Sep 5, 2024

🤖 Pull Request Artifacts (#10762459309) 🎉

Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using PyCharm, right-click on the file from the sidebar and Reformat. It will fix the import order and the file formatting.

riocli/deployment/inspect.py Outdated Show resolved Hide resolved
riocli/deployment/inspect.py Outdated Show resolved Hide resolved
@pallabpain pallabpain changed the title Added guid support for deployment resource inspection fix(deployment): inspect deployment with guid Sep 5, 2024
@YaswanthKumar-eng YaswanthKumar-eng force-pushed the support-guid-param branch 3 times, most recently from 38bd720 to ad67faf Compare September 6, 2024 06:52
@pallabpain pallabpain added the 🐛 bug Something isn't working label Sep 8, 2024
@pallabpain pallabpain force-pushed the support-guid-param branch 2 times, most recently from 6954a6c to 926f2db Compare September 8, 2024 19:10
This commit fixes the rio deployment inspect command to work with deployment guids.

Azure Ticket:https://dev.azure.com/rapyuta-robotics/platform/_workitems/edit/16472
@pallabpain pallabpain merged commit a34bd0a into devel Sep 8, 2024
7 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Sep 25, 2024
# [9.0.0](v8.1.0...v9.0.0) (2024-09-25)

### Bug Fixes

* **apply:** prints resource name when apply or delete fails ([1952929](1952929))
* **configtree:** corrects typo in error message ([2b0edde](2b0edde))
* **configtree:** returns error when no files are provided in import ([843b793](843b793))
* corrects error message for batch delete ops ([48447d4](48447d4))
* **delete:** prints appropriate message when deletionPolicy = retain ([7c76d84](7c76d84))
* **deployment:** add phase filter for list_deployments ([a545c1e](a545c1e))
* **deployment:** fix deployment commands ([6f2aec2](6f2aec2))
* **deployment:** inspect deployment with guid ([#349](#349)) ([a34bd0a](a34bd0a))
* **deployment:** replace aggregateStatus with status ([9ae1cee](9ae1cee))
* **deployments:** adds stopped at time for deployment list ([7891a5c](7891a5c))
* **deployment:** set replica=0 as default in deployment logs command ([e9f4668](e9f4668))
* **deployments:** fix deployment status and wait command ([0e3ea14](0e3ea14))
* **deployments:** fix deployment wait command ([e0ef5ed](e0ef5ed))
* **deployments:** implements waiting mechanism for disk and network deployments to reach running state ([7e2f0d4](7e2f0d4))
* **device:** updates client in list device deployments command ([18b4c50](18b4c50))
* **disk:** fix disk commands ([2060d7c](2060d7c))
* **disk:** prints a better message when no disks are deleted ([dbe83e4](dbe83e4))
* fixes resolver and resource models to work with apply ([8279b77](8279b77))
* **jsonschema:** accepts null value in deployment features ([1791b29](1791b29))
* **jsonschema:** corrects resource GUID regex ([8252a71](8252a71))
* **jsonschema:** remove interface from deployment rosNetworks ([f8c2a9a](f8c2a9a))
* **manifests:** fix manifests of resources ([4f5e9bb](4f5e9bb))
* **network:** fix network commands ([7f06c67](7f06c67))
* **networks:** delete in use network ([a9d2c49](a9d2c49))
* **networks:** fix device network schema ([7ebabf0](7ebabf0))
* **networks:** fix network type flag ([64bc9e3](64bc9e3))
* **package:** allow executable command to be string, array or null ([c97b186](c97b186))
* **packages:** fix package commands ([48a92c9](48a92c9))
* **project:** fixes raised exception in find_organization_guid helper ([6ab3838](6ab3838))
* **rosbag:** update default statuses for list functions ([54fd266](54fd266))
* **template:** validate manifests against jsonschema ([b9f9fc4](b9f9fc4))
* **v2client:** corrects status check in poll_disk ([c6e7a8b](c6e7a8b))
* **v2client:** fix retry exceeded error code description and action ([938ed4c](938ed4c))
* **v2client:** fix v2 client org header ([313c660](313c660))

### Features

* adds filter by label option in list commands ([0c2cfe8](0c2cfe8))
* **apply:** init Jinja environment with filters and rio namespace ([7dc030d](7dc030d))
* **config:** store org short id in the cli config ([9c9a6fa](9c9a6fa))
* **context:** add command to view cli config ([763e712](763e712))
* **deployment:** execute commands on device deployments ([#345](#345)) ([558215b](558215b))
* **deployment:** implement restart alias for rio deployment update ([a25a85b](a25a85b))
* **deployment:** uses v2 deployments APIs ([bc33295](bc33295))
* **deployment:** wait until all dependecies are running ([71d4f0a](71d4f0a))
* **disks:** use v2 APIs for Disk operations ([3ddb694](3ddb694))
* **networks:** uses v2 networks APIs ([d967d18](d967d18))
* **packages:** uses v2 packages APIs ([1048ff5](1048ff5))
* **scripts:** adds install script for appimages ([#354](#354)) ([3677bc6](3677bc6))
* **v2client:** adds poll methods and stream deployment logs method ([af90e83](af90e83))
* **v2client:** inject X-Request-ID in headers if REQUEST_ID in env ([5ce15f1](5ce15f1))

### Performance Improvements

* **delete:** implements multi-threaded delete operation ([a50fec0](a50fec0))

### BREAKING CHANGES

* **deployment:** The rio deployment execute command no longer supports cloud deployments.
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 9.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the support-guid-param branch October 14, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants