fix(secret): corrects list secret command #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a recent refactor in the v2 client library, the list secrets function now returns the entire secret objects instead of just reading the metadata in the previous implementation. This changed object altogther and the way other sections of code fetched the secret name. This commit addresses the issue by correcting the list_secrets function.
|
🤖 Pull Request Artifacts (#9158794819) 🎉 |
ankitrgadiya
approved these changes
May 20, 2024
pallabpain
changed the title
pallabpain
approved these changes
May 20, 2024
rr-github-ci-user
pushed a commit
that referenced
this pull request
Jun 12, 2024
# [7.5.0](v7.4.1...v7.5.0) (2024-06-12) ### Bug Fixes * **configtree:** fix handling org-level tree revisions in statefile ([05d2a27](05d2a27)) * **configtree:** fix revision keys command to correctly show revision keys ([0ac9988](0ac9988)) * **explain:** add livenessProbe constraints in the samples ([4e34695](4e34695)) * **package:** corrects exec command parsing ([#312](#312)) ([1f0a271](1f0a271)) * **secret:** corrects corresponding list functions ([#310](#310)) ([34b5c0b](34b5c0b)) ### Features * **device:** add support for migrating device between projects ([ad70aed](ad70aed)) * **project:** adds command to update project owner ([5b4340e](5b4340e)) * **utils:** extends show_selection helper ([ce1a927](ce1a927))
|
🎉 This PR is included in version 7.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent refactor in the v2 client library, the list secrets function now returns the entire
secret objects instead of just reading the metadata in the previous implementation. This changed object altogther and the way other sections of code fetched the secret name.
This commit addresses the issue by correcting the
list_secrets function.