🐛 fix(apply): raises error when a metadata has no name #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a resource manifest has no name in metadata, it throws a KeyError. This commit fixes the error reporting to state the issue more explicitly. Wrike Ticket: https://www.wrike.com/open.htm?id=1238536095
pallabpain
force-pushed
the
fix/metadata-name
branch
from
c4b416d to
441e345
Compare
|
🤖 Pull Request Artifacts (#7741314961) 🎉 |
|
🤖 Pull Request Artifacts (#7741324579) 🎉 |
RomilShah
approved these changes
Feb 1, 2024
rr-github-ci-user
pushed a commit
that referenced
this pull request
Feb 2, 2024
## [7.0.2](v7.0.1...v7.0.2) (2024-02-02) ### Bug Fixes * **apply:** raises error when a metadata has no name ([#266](#266)) ([be26ff8](be26ff8)) * **deployment:** corrects the condition to fetch deployments ([ee1265d](ee1265d)) * **device:** corrects the condition to fetch devices ([3785f33](3785f33)) * **jsonschema:** corrects the deployment component spec ([#264](#264)) ([3f848bf](3f848bf)) * **package:** corrects the condition to fetch packages ([f056d3a](f056d3a))
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
When a resource manifest has no name in metadata, it throws a KeyError. This commit fixes the error reporting to state the issue more explicitly. Wrike Ticket: https://www.wrike.com/open.htm?id=1238536095
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
## [7.0.2](v7.0.1...v7.0.2) (2024-02-02) ### Bug Fixes * **apply:** raises error when a metadata has no name ([#266](#266)) ([be26ff8](be26ff8)) * **deployment:** corrects the condition to fetch deployments ([ee1265d](ee1265d)) * **device:** corrects the condition to fetch devices ([3785f33](3785f33)) * **jsonschema:** corrects the deployment component spec ([#264](#264)) ([3f848bf](3f848bf)) * **package:** corrects the condition to fetch packages ([f056d3a](f056d3a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a resource manifest has no name in metadata, it throws a KeyError. This commit fixes the error reporting to state the issue more explicitly.