Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonschema): corrects deployment component spec #264

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

pallabpain
Copy link
Contributor

@pallabpain pallabpain commented Feb 1, 2024

Description

The depends attribute of the deployment schema is defined under the componentSpec which violates the additionalProperties=False setting of the dependencies for each runtime. This commit correct that by explicitly adding the depends section for each runtime.

The spec.

spec:
  runtime: device
  device:
    depends:
      kind: device
      nameOrGUID: "{{ device.edge.name }}"
  depends:
    - kind: deployment
      nameOrGUID: oks_server

The error.

>> :white_tick: Updated deployment:oks_web_interface                                                                                                [2024-02-01T12:23:19.016449]
:x: Apply failed. Error: {'runtime': 'device', 'device': {'depends': {'kind': 'device', 'nameOrGUID': 'edge01', 'guid': '3d6e8b0f-d3f1-4750-898e-253eb08e414e'}}, 'depends': [{'kind': 'deployment', 'nameOrGUID': 'oks_db', 'guid': 'dep-hgvpzjvinzialeseondtqkrf'}]} is not valid under any of the given schemas

The depends attribute of the deployment schema is defined under the
componentSpec which violates the additionalProperties=False setting of
the dependencies for each runtime. This commit correct that by
explicitly adding the depends section for each runtime.
@pallabpain pallabpain requested review from a team as code owners February 1, 2024 04:11
Copy link

github-actions bot commented Feb 1, 2024

🤖 Pull Request Artifacts (#7736140731) 🎉

@pallabpain pallabpain self-assigned this Feb 1, 2024
@pallabpain pallabpain added the 🐛 bug Something isn't working label Feb 1, 2024
@pallabpain pallabpain changed the title fix(jsonschema): correct deployment component spec fix(jsonschema): corrects deployment component spec Feb 1, 2024
@pallabpain pallabpain merged commit 3f848bf into devel Feb 1, 2024
6 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Feb 2, 2024
## [7.0.2](v7.0.1...v7.0.2) (2024-02-02)

### Bug Fixes

* **apply:** raises error when a metadata has no name ([#266](#266)) ([be26ff8](be26ff8))
* **deployment:** corrects the condition to fetch deployments ([ee1265d](ee1265d))
* **device:** corrects the condition to fetch devices ([3785f33](3785f33))
* **jsonschema:** corrects the deployment component spec ([#264](#264)) ([3f848bf](3f848bf))
* **package:** corrects the condition to fetch packages ([f056d3a](f056d3a))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 7.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

RomilShah pushed a commit that referenced this pull request Apr 23, 2024
The depends attribute of the deployment schema is defined under the
componentSpec which violates the additionalProperties=False setting of
the dependencies for each runtime. This commit correct that by
explicitly adding the depends section for each runtime.
RomilShah pushed a commit that referenced this pull request Apr 23, 2024
## [7.0.2](v7.0.1...v7.0.2) (2024-02-02)

### Bug Fixes

* **apply:** raises error when a metadata has no name ([#266](#266)) ([be26ff8](be26ff8))
* **deployment:** corrects the condition to fetch deployments ([ee1265d](ee1265d))
* **device:** corrects the condition to fetch devices ([3785f33](3785f33))
* **jsonschema:** corrects the deployment component spec ([#264](#264)) ([3f848bf](3f848bf))
* **package:** corrects the condition to fetch packages ([f056d3a](f056d3a))
@ankitrgadiya ankitrgadiya deleted the test/bugs branch May 28, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants