fix(project): fixes project update with vpn state #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the project update API was updated to reflect the state as sent in the request payload. The vpn command in project had the older implementation and we forgot to update it when the project update API was changed. This issue can lead to serious loss of project info if not fixed in time. This commit corrects that by first fetching the project and updating it with the new values before passing it as the payload for update.
|
🤖 Pull Request Artifacts (#7206038636) 🎉 |
ankitrgadiya
approved these changes
Dec 15, 2023
rr-github-ci-user
pushed a commit
that referenced
this pull request
Dec 28, 2023
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28) ### Bug Fixes * **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6)) ### Features * **auth:** add support for AKS staging environments ([59d30e9](59d30e9)) * **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521)) * **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403)) * **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332)) * **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f)) ### BREAKING CHANGES * **jsonschema:** The vpn and tracing attributes under .spec.features have been changed from type=boolean to type=object. Enabling vpn on a project will now require one to set .spec.features.vpn.enabled=True and likewise for any other project feature.
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28) ### Bug Fixes * **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6)) ### Features * **auth:** add support for AKS staging environments ([59d30e9](59d30e9)) * **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521)) * **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403)) * **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332)) * **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f)) ### BREAKING CHANGES * **jsonschema:** The vpn and tracing attributes under .spec.features have been changed from type=boolean to type=object. Enabling vpn on a project will now require one to set .spec.features.vpn.enabled=True and likewise for any other project feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, the project update API was updated to reflect the state as sent in the request payload. The vpn command in project had the older implementation and we forgot to update it when the project update API was changed. This issue can lead to serious loss of project info if not fixed in time. This commit corrects that by first fetching the project and updating it with the new values before passing it as the payload for update.
For example, created a new project with a few labels or add one or more users or groups. Then run
rio project features vpn {PROJECT_NAME} true. You will notice that inrio project inspect {PROJECT_NAME}, the labels or users are gone except the admins.However, with the fix, things should be fine.