-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(device): updates device delete command to delete multiple devices #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
changed the title
feat(device): updates device delete command to delete multiple devices
✨ feat(device): updates device delete command to delete multiple devices
Aug 8, 2023
pallabpain
requested changes
Aug 8, 2023
RomilShah
force-pushed
the
feat/delete_device_regex
branch
5 times, most recently
from
August 8, 2023 14:32
40ce104
to
c7df7a3
Compare
pallabpain
force-pushed
the
feat/delete_device_regex
branch
from
August 11, 2023 08:30
c7df7a3
to
78d58db
Compare
pallabpain
requested changes
Aug 21, 2023
RomilShah
force-pushed
the
feat/delete_device_regex
branch
from
August 22, 2023 08:30
bcaff10
to
9e490f3
Compare
pallabpain
reviewed
Sep 2, 2023
pallabpain
reviewed
Sep 4, 2023
pallabpain
reviewed
Sep 4, 2023
This commit updates device delete command that enables users to conveniently delete existing devices by providing device name or regex that can delete multiple devices Usage: python -m rio device delete [OPTIONS] [DEVICE_NAME_OR_REGEX] Deletes one more devices Options: -f, --force, --silent Skip confirmation -a, --delete-all Deletes all devices -w, --workers INTEGER number of parallel workers while running delete device command. defaults to 10. --help Show this message and exit.
RomilShah
force-pushed
the
feat/delete_device_regex
branch
from
September 26, 2023 06:57
e18681f
to
5f14b25
Compare
🤖 Pull Request Artifacts (#6309160703) 🎉 |
pallabpain
approved these changes
Nov 9, 2023
rr-github-ci-user
pushed a commit
that referenced
this pull request
Dec 28, 2023
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28) ### Bug Fixes * **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6)) ### Features * **auth:** add support for AKS staging environments ([59d30e9](59d30e9)) * **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521)) * **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403)) * **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332)) * **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f)) ### BREAKING CHANGES * **jsonschema:** The vpn and tracing attributes under .spec.features have been changed from type=boolean to type=object. Enabling vpn on a project will now require one to set .spec.features.vpn.enabled=True and likewise for any other project feature.
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28) ### Bug Fixes * **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6)) ### Features * **auth:** add support for AKS staging environments ([59d30e9](59d30e9)) * **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521)) * **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403)) * **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332)) * **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f)) ### BREAKING CHANGES * **jsonschema:** The vpn and tracing attributes under .spec.features have been changed from type=boolean to type=object. Enabling vpn on a project will now require one to set .spec.features.vpn.enabled=True and likewise for any other project feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit updates device delete command that enables users to conveniently delete existing devices by providing device name or regex that can delete multiple devices
Demo