Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(device): updates device delete command to delete multiple devices #217

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

RomilShah
Copy link
Contributor

@RomilShah RomilShah commented Aug 8, 2023

Description

This commit updates device delete command that enables users to conveniently delete existing devices by providing device name or regex that can delete multiple devices

Usage: rio device delete [OPTIONS] [DEVICE_NAME_OR_REGEX]

  Deletes one more devices

Options:
  -f, --force, --silent  Skip confirmation
  -a, --delete-all       Deletes all devices
  -w, --workers INTEGER  number of parallel workers while running delete device command. defaults to 10.
  --help                 Show this message and exit.

Demo

asciicast

@RomilShah RomilShah requested review from a team as code owners August 8, 2023 05:17
@pallabpain pallabpain changed the title feat(device): updates device delete command to delete multiple devices ✨ feat(device): updates device delete command to delete multiple devices Aug 8, 2023
@pallabpain pallabpain added the 🔨 refactor Improvements in an existing feature label Aug 8, 2023
riocli/device/delete.py Outdated Show resolved Hide resolved
riocli/device/delete.py Outdated Show resolved Hide resolved
@RomilShah RomilShah force-pushed the feat/delete_device_regex branch 5 times, most recently from 40ce104 to c7df7a3 Compare August 8, 2023 14:32
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 8, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 8, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 8, 2023
@pallabpain pallabpain force-pushed the feat/delete_device_regex branch from c7df7a3 to 78d58db Compare August 11, 2023 08:30
riocli/device/delete.py Outdated Show resolved Hide resolved
riocli/device/delete.py Outdated Show resolved Hide resolved
riocli/device/delete.py Outdated Show resolved Hide resolved
@RomilShah RomilShah force-pushed the feat/delete_device_regex branch from bcaff10 to 9e490f3 Compare August 22, 2023 08:30
riocli/device/delete.py Outdated Show resolved Hide resolved
riocli/device/util.py Outdated Show resolved Hide resolved
riocli/device/util.py Outdated Show resolved Hide resolved
This commit updates device delete command that enables users
to conveniently delete existing devices by providing device
name or regex that can delete multiple devices

Usage: python -m rio device delete [OPTIONS] [DEVICE_NAME_OR_REGEX]

  Deletes one more devices

Options:
  -f, --force, --silent  Skip confirmation
  -a, --delete-all       Deletes all devices
  -w, --workers INTEGER  number of parallel workers while running delete device command. defaults to 10.
  --help                 Show this message and exit.
@RomilShah RomilShah force-pushed the feat/delete_device_regex branch from e18681f to 5f14b25 Compare September 26, 2023 06:57
@github-actions
Copy link

🤖 Pull Request Artifacts (#6309160703) 🎉

@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Sep 26, 2023
@pallabpain pallabpain merged commit 1a35403 into devel Nov 9, 2023
7 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Dec 28, 2023
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28)

### Bug Fixes

* **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6))

### Features

* **auth:** add support for AKS staging environments ([59d30e9](59d30e9))
* **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521))
* **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403))
* **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332))
* **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f))

### BREAKING CHANGES

* **jsonschema:** The vpn and tracing attributes under .spec.features
have been changed from type=boolean to type=object. Enabling vpn on a
project will now require one to set .spec.features.vpn.enabled=True and
likewise for any other project feature.
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

RomilShah pushed a commit that referenced this pull request Apr 23, 2024
# [6.0.0](v5.0.0...v6.0.0) (2023-12-28)

### Bug Fixes

* **project:** fixes project update with vpn state ([#246](#246)) ([82709f6](82709f6))

### Features

* **auth:** add support for AKS staging environments ([59d30e9](59d30e9))
* **device:** adds --advertise-routes flag in the vpn command ([6cea521](6cea521))
* **device:** updates device delete command to delete multiple devices ([#217](#217)) ([1a35403](1a35403))
* **jsonschema:** updates features attribute in project schema ([c4cd332](c4cd332))
* **project:** accepts subnets while enabling vpn ([#245](#245)) ([06bbf7f](06bbf7f))

### BREAKING CHANGES

* **jsonschema:** The vpn and tracing attributes under .spec.features
have been changed from type=boolean to type=object. Enabling vpn on a
project will now require one to set .spec.features.vpn.enabled=True and
likewise for any other project feature.
@ankitrgadiya ankitrgadiya deleted the feat/delete_device_regex branch May 28, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 refactor Improvements in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants