✨ feat(vpn): adds spinner and refactors implementation #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Pull Request Artifacts (#5459246683) 🎉 |
pallabpain
added
🔨 refactor
ankitrgadiya
reviewed
Jul 6, 2023
|
🤖 Pull Request Artifacts (#5472894075) 🎉 |
|
🤖 Pull Request Artifacts (#5473098875) 🎉 |
pallabpain
force-pushed
the
feature/updates-spinner-in-vpn
branch
from
925d692 to
13029cb
Compare
|
🤖 Pull Request Artifacts (#5473147690) 🎉 |
ankitrgadiya
approved these changes
Jul 6, 2023
pallabpain
added a commit
that referenced
this pull request
Aug 3, 2023
This commit introduces a spinner in vpn commands and some minor refactors.
rr-github-ci-user
pushed a commit
that referenced
this pull request
Aug 3, 2023
# [4.0.0](v3.1.0...v4.0.0) (2023-08-03) ### Bug Fixes * **apply:** corrects the guid_functor for network ([347e430](347e430)) * **deployment:** handles error in name_to_guid ([47b5f8f](47b5f8f)) * **deployment:** sets dependent deployment ready phase to PROVISIONING ([1444186](1444186)) * **jsonschema:** adds regex pattern to usergroup schema ([9235863](9235863)) * **jsonschema:** updates the projectGUID regex pattern ([63b975e](63b975e)) * **network:** handles error in name_to_guid ([2f73774](2f73774)) * **organization:** fixes KeyError in organization users command ([6b3c867](6b3c867)) * **parameter:** fixes nested directory diff ([7445972](7445972)) * **usergroup:** fixes create_object method signature ([d74f539](d74f539)) * **usergroup:** handles NoneType error in inspect command ([3b111a6](3b111a6)) * **usergroup:** update usergroup removes active admins ([ca67437](ca67437)) ### Features * adds command to update the CLI ([c64c9d7](c64c9d7)) * **apply:** adds retry count and sleep interval flags ([1cdeb65](1cdeb65)) * **apply:** adds yaspin spinner to apply family of commands ([c6e0975](c6e0975)) * **auth:** updates spinner and refactors existing code ([dd33d75](dd33d75)) * **chart:** adds spinner and refactors code ([ff28002](ff28002)) * **constants:** defines colors and symbols as constants ([8ad2cad](8ad2cad)) * **deployment:** adds command to update deployments ([e04e5dd](e04e5dd)) * **deployment:** updates spinner and refactors existing code ([458b44e](458b44e)) * **device:** adds or updates spinner in device commands ([c14ebf4](c14ebf4)) * **disk:** list command shows used and available capacity ([0361904](0361904)) * **disk:** updates spinner and existing implementation ([4c080d0](4c080d0)) * **network:** updates spinner and refactors existing commands ([e0621dc](e0621dc)) * **organization:** adds command to list users ([19a06f8](19a06f8)) * **organiztion:** adds option to set project non-interactively ([3c2e848](3c2e848)) * **parameter:** adds spinner and constants ([a4f954e](a4f954e)) * **project:** adds yaspin implementation to project commands ([44a5a1c](44a5a1c)) * **secret:** updates spinner and refactors existing commands ([0949154](0949154)) * **static-route:** updates spinner and other implementations ([7184016](7184016)) * **usergroup:** adds usergroup command ([c57891e](c57891e)) * **vpn:** adds spinner and refactors implementation ([#188](#188)) ([0af180f](0af180f)) ### Performance Improvements * **deployment:** poll deployment till provisioning phase ([ea72999](ea72999)) ### BREAKING CHANGES * **deployment:** Deployment will be polled till provisioning
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [4.0.0](v3.1.0...v4.0.0) (2023-08-03) ### Bug Fixes * **apply:** corrects the guid_functor for network ([347e430](347e430)) * **deployment:** handles error in name_to_guid ([47b5f8f](47b5f8f)) * **deployment:** sets dependent deployment ready phase to PROVISIONING ([1444186](1444186)) * **jsonschema:** adds regex pattern to usergroup schema ([9235863](9235863)) * **jsonschema:** updates the projectGUID regex pattern ([63b975e](63b975e)) * **network:** handles error in name_to_guid ([2f73774](2f73774)) * **organization:** fixes KeyError in organization users command ([6b3c867](6b3c867)) * **parameter:** fixes nested directory diff ([7445972](7445972)) * **usergroup:** fixes create_object method signature ([d74f539](d74f539)) * **usergroup:** handles NoneType error in inspect command ([3b111a6](3b111a6)) * **usergroup:** update usergroup removes active admins ([ca67437](ca67437)) ### Features * adds command to update the CLI ([c64c9d7](c64c9d7)) * **apply:** adds retry count and sleep interval flags ([1cdeb65](1cdeb65)) * **apply:** adds yaspin spinner to apply family of commands ([c6e0975](c6e0975)) * **auth:** updates spinner and refactors existing code ([dd33d75](dd33d75)) * **chart:** adds spinner and refactors code ([ff28002](ff28002)) * **constants:** defines colors and symbols as constants ([8ad2cad](8ad2cad)) * **deployment:** adds command to update deployments ([e04e5dd](e04e5dd)) * **deployment:** updates spinner and refactors existing code ([458b44e](458b44e)) * **device:** adds or updates spinner in device commands ([c14ebf4](c14ebf4)) * **disk:** list command shows used and available capacity ([0361904](0361904)) * **disk:** updates spinner and existing implementation ([4c080d0](4c080d0)) * **network:** updates spinner and refactors existing commands ([e0621dc](e0621dc)) * **organization:** adds command to list users ([19a06f8](19a06f8)) * **organiztion:** adds option to set project non-interactively ([3c2e848](3c2e848)) * **parameter:** adds spinner and constants ([a4f954e](a4f954e)) * **project:** adds yaspin implementation to project commands ([44a5a1c](44a5a1c)) * **secret:** updates spinner and refactors existing commands ([0949154](0949154)) * **static-route:** updates spinner and other implementations ([7184016](7184016)) * **usergroup:** adds usergroup command ([c57891e](c57891e)) * **vpn:** adds spinner and refactors implementation ([#188](#188)) ([0af180f](0af180f)) ### Performance Improvements * **deployment:** poll deployment till provisioning phase ([ea72999](ea72999)) ### BREAKING CHANGES * **deployment:** Deployment will be polled till provisioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds spinner in the vpn commands and refactors a part of the implementation.