fix(device): convert PosixPath to str #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_remote_path utility function returns `PosixPath` class, but the functions later expect a string as parameter. This commit adds the `as_posix()` call which converts the class into a `str` fixing this bug.
wiresurfer
reviewed
Nov 12, 2021
ankitrgadiya
added a commit
that referenced
this pull request
Dec 27, 2021
The is_remote_path utility function returns `PosixPath` class, but the functions later expect a string as parameter. This commit adds the `as_posix()` call which converts the class into a `str` fixing this bug.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 27, 2021
# [0.2.0](v0.1.1...v0.2.0) (2021-12-27) ### Bug Fixes * **device:** convert PosixPath to str ([#1](#1)) ([5346e54](5346e54)) * **device:** fixes the device inspect command ([5f76295](5f76295)) * **network:** ROS distro is corrected to noetic ([#7](#7)) ([837352b](837352b)) * **package:** fixes handling for wrong name ([4607022](4607022)) * **static-route:** fixes the name to guid behaviour for hyphenated names ([7bd5b8e](7bd5b8e)) ### Features * **marketplace:** support for marketplace bulk install ([182fab9](182fab9)) * **network:** adds device native network support ([020b096](020b096))
ankitrgadiya
pushed a commit
that referenced
this pull request
Mar 14, 2022
# [0.2.0](v0.1.1...v0.2.0) (2021-12-27) ### Bug Fixes * **device:** convert PosixPath to str ([#1](#1)) ([5346e54](5346e54)) * **device:** fixes the device inspect command ([5f76295](5f76295)) * **network:** ROS distro is corrected to noetic ([#7](#7)) ([837352b](837352b)) * **package:** fixes handling for wrong name ([4607022](4607022)) * **static-route:** fixes the name to guid behaviour for hyphenated names ([7bd5b8e](7bd5b8e)) ### Features * **marketplace:** support for marketplace bulk install ([182fab9](182fab9)) * **network:** adds device native network support ([020b096](020b096))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is_remote_path utility function returns
PosixPathclass, but the functions later expect a string as parameter. This commit adds theas_posix()call which converts the class into astrfixing this bug.