Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test_utils subpackage and test_utils/test_comms.py to avoid pytest conflicts #133

Open
vyasr opened this issue Feb 12, 2024 · 0 comments
Assignees
Milestone

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 12, 2024

pytest will assume that any file or directory named test_* is a test (see pytest's discovery rules). wholegraph currently puts testing utilities into a file that fits this description, which causes various issues with test discovery (and import order because test_utils is a package and not just a module, which causes additional problems for pytest) depending on exactly what path is used to run the tests. We worked around some of these in #128, but it would be best if this subpackage and the test_comms.py file it contains could be renamed with a different prefix like testing to avoid this conflict.

@BradReesWork BradReesWork added this to the 24.06 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants