Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up: use std::size_t, include cstddef and aligned.hpp where missing #852

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Clean up: use std::size_t, include cstddef and aligned.hpp where missing #852

merged 5 commits into from
Aug 30, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Aug 25, 2021

Adds missing includes of rmm/detail/aligned.hpp and cstddef wherever needed, and converts size_t to std::size_t thoughout RMM. A few other minor header ordering updates, and replacing quoted includes with angle bracket includes.

Fixes #848

@harrism harrism requested a review from a team as a code owner August 25, 2021 03:30
@github-actions github-actions bot added the cpp Pertains to C++ code label Aug 25, 2021
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 25, 2021
@harrism harrism self-assigned this Aug 25, 2021
rongou
rongou approved these changes Aug 25, 2021
View reviewed changes
include/rmm/cuda_stream_pool.hpp Outdated Show resolved Hide resolved
codereport
codereport approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@harrism
Copy link
Member Author

harrism commented Aug 25, 2021

@gpucibot merge

@harrism
Copy link
Member Author

harrism commented Aug 25, 2021

rerun tests

@jrhemstad
Copy link
Contributor

rerun tests

@harrism
Copy link
Member Author

harrism commented Aug 27, 2021

Rerun tests

@rapids-bot rapids-bot bot merged commit 71b5391 into rapidsai:branch-21.10 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@rongou rongou rongou approved these changes

Assignees

@harrism harrism

Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing #include <rmm/detail/aligned.hpp> in pinned_memory_resource.hpp
4 participants
@harrism @jrhemstad @rongou @codereport