Use rapids-build-backend. #1502

bdice · 2024-03-13T20:05:38Z

Description

This PR uses rapids-build-backend to simplify wheel builds and reduce the complexity of various CI/build scripts.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

python/pyproject.toml

…ds_build_backend

ci/build_wheel.sh

…d_backend

jameslamb · 2024-05-21T21:19:59Z

Yep that worked (build link), thanks @vyasr

vyasr

Couple of small things, but approving since I don't need to look at this again unless something comes up.

ci/build_python.sh

dependencies.yaml

vyasr

Just noticed this in the raft PR and it reminded me: do we also need to add a disable-cuda in the build.sh invocations?

KyleFromNVIDIA · 2024-05-23T14:24:37Z

do we also need to add a disable-cuda in the build.sh invocations?

Yes, but it needs to be rapidsai.disable-cuda once rapidsai/rapids-build-backend#37 is merged.

jameslamb · 2024-05-23T19:22:02Z

Alright I've updated this with the following changes:

moved rapids-build-backend floor to 0.3.0
passed --config-settings rapidsai.disable-cude=true in build.sh
consolidated rapids-generate-version calls based on Use rapids-build-backend. #1502 (comment)
changed librmm/_version.py to also use the __package__ pattern (instead of string literal "librmm")
added __all__ lists to _version.py
- (noticed @KyleFromNVIDIA doing this in Use rapids-build-backend cuml#5804, I think it's nice to clarify intent and to avoid re-exporting other things from that module)

That's enough changes that I think this should get another review if you have time @vyasr .

vyasr

Couple more small notes, but approving assuming that they're addressed.

ci/build_cpp.sh

dependencies.yaml

….sh changes

jameslamb · 2024-05-24T18:35:26Z

build.sh

+    SKBUILD_CMAKE_ARGS="${EXTRA_CMAKE_ARGS}" python -m pip install \
+        --no-build-isolation \
+        --no-deps \
+        --config-settings rapidsai.disable-cuda=true \


I just pushed one more change... remembered that pip accepts --config-settings (with an s), not --config-setting.

https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-C

Having --config-setting (no s) didn't break anything in CI or even display any warnings, so maybe newer versions of pip have code to capture both. But either way, I think --config-settings (with the s) is the right thing for pip install, given that's what is in that tool's docs.

I'll apply that change to the cudf PR. cc @KyleFromNVIDIA that should be applied to the other rapids-build-backend PRs as well.

jameslamb · 2024-05-24T18:37:12Z

I just pushed one more tiny change (#1502 (comment)).

I think all the review comments have been addressed, so if CI passes, I'll merge this.

jameslamb · 2024-05-24T21:55:39Z

/merge

Contributes to rapidsai/build-planning#31 Follow-up to #1502 * ensures that `update-version.sh` does not remove alpha specs like `,>=0.0.0a0` in `pyproject.toml` and conda environment files * consolidates `rapids-build-backend` versions in `dependencies.yaml` - *since I was pushing a new commit here anyway, figured I'd take the opportunity to include that simplification recommended in rapidsai/cudf#15245 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #1572

…build-backend configuration (#1582) Contributes to rapidsai/build-planning#31 Contributes to rapidsai/dependency-file-generator#89 #1502 was one of the first `rapids-build-backend` PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `rmm` up with those changes: * consolidates version-handling in `ci/build_cpp.sh` * removes `commit-file` configuration in `pyproject.toml` - *as of rapidsai/rapids-build-backend#30, this is no longer necessary if the project's top-level directory is `{project_name}.replace("-", "_")* - *and anyway, it was changed from `commit-file` to `commit-files` in that PR, so `commit-file` was being silently ignored here* * uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1582

trivialfis · 2024-07-12T11:26:08Z

I think the README file needs to be updated.

jakirkham · 2024-07-12T20:23:45Z

Could you please raise this in an issue or PR?

trivialfis · 2024-07-13T15:09:48Z

@jakirkham Opened an issue here: #1609 .

Fixes #1609 Follow-up to #1502 Adds `rapids-build-backend` to the documentation on how to build `rmm` from source. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Jiaming Yuan (https://github.com/trivialfis) URL: #1614

Use rapids-build-backend.

8ffedf2

github-actions bot added Python Related to RMM Python API conda ci labels Mar 13, 2024

bdice added 5 commits March 14, 2024 10:26

Update dependencies.

f5e6177

Use build module.

008b20c

Fix pyproject.toml.

2d4c846

Fix key.

ab0b17a

Read GIT_COMMIT.

0a2e648

KyleFromNVIDIA reviewed Mar 14, 2024

View reviewed changes

python/pyproject.toml Outdated Show resolved Hide resolved

bdice added 4 commits March 14, 2024 12:46

Merge branch 'branch-24.04' into rapids_build_backend

697f340

Install rapids-build-backend.

10ccd85

Merge branch 'rapids_build_backend' of github.com:bdice/rmm into rapi…

f29fa7a

…ds_build_backend

Fix build-system.requires until packages are available.

952dedc

vyasr reviewed Mar 14, 2024

View reviewed changes

ci/build_wheel.sh Outdated Show resolved Hide resolved

Update for changes in rapids-build-backend.

1301e60

bdice added non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function labels Mar 15, 2024

bdice added 3 commits March 15, 2024 07:48

Use pip wheel for wheel builds to find it during installation.

e4a5abf

Fix scikit-build-core to include pyproject extras.

ee87798

Add dependency on rapids-build-backend.

8c9c4df

bdice force-pushed the rapids_build_backend branch from 4eca92d to 8c9c4df Compare March 15, 2024 20:16

bdice added 2 commits March 18, 2024 18:34

Remove testing hacks now that packages are available.

747a28c

Merge remote-tracking branch 'upstream/branch-24.06' into rapids_buil…

8a28056

…d_backend

bdice changed the base branch from branch-24.04 to branch-24.06 March 18, 2024 23:35

bdice and others added 4 commits March 18, 2024 18:53

Update conda recipe.

9def158

Add rapidsai-nightly to dependencies.yaml.

ee886d5

merge latest branch-24.06

ba766dd

fix link in README

92949db

jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 21, 2024

vyasr approved these changes May 23, 2024

View reviewed changes

ci/build_python.sh Outdated Show resolved Hide resolved

dependencies.yaml Outdated Show resolved Hide resolved

vyasr reviewed May 23, 2024

View reviewed changes

jameslamb added 5 commits May 23, 2024 11:35

Merge branch 'branch-24.08' into rapids_build_backend

32f623f

upgrade to v0.3.0, consolidate rapids-generate-version uses

c6e522c

rapids-dependency-file-generator version

cc76e35

populate __all__ in _version.py

b9a31fb

set 'rapidsai.disable-cuda=true' in conda builds

4aab1c3

jameslamb requested a review from vyasr May 23, 2024 20:02

vyasr approved these changes May 23, 2024

View reviewed changes

ci/build_cpp.sh Outdated Show resolved Hide resolved

dependencies.yaml Outdated Show resolved Hide resolved

jameslamb added 2 commits May 24, 2024 06:56

standardize rapids-build-backend version constraint, revert build_cpp…

7aeba94

….sh changes

--config-settings, not --config-setting, for pip

1a9b4f1

jameslamb reviewed May 24, 2024

View reviewed changes

rapids-bot bot merged commit 15c0466 into rapidsai:branch-24.08 May 24, 2024
57 checks passed

jameslamb mentioned this pull request May 29, 2024

ensure update-version.sh preserves alpha specs #1572

Merged

3 tasks

jameslamb mentioned this pull request Jun 11, 2024

resolve dependency-file-generator warning, remove unnecessary rapids-build-backend configuration #1582

Merged

3 tasks

trivialfis mentioned this pull request Jul 13, 2024

[DOC] Update readme file for build instructions. #1609

Closed

jameslamb mentioned this pull request Jul 16, 2024

add rapids-build-backend to docs #1614

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use rapids-build-backend. #1502

Use rapids-build-backend. #1502

bdice commented Mar 13, 2024 •

edited by jameslamb

Loading

jameslamb commented May 21, 2024

vyasr left a comment

vyasr left a comment

KyleFromNVIDIA commented May 23, 2024

jameslamb commented May 23, 2024

vyasr left a comment

jameslamb May 24, 2024

jameslamb commented May 24, 2024

jameslamb commented May 24, 2024

trivialfis commented Jul 12, 2024

jakirkham commented Jul 12, 2024

trivialfis commented Jul 13, 2024

Use rapids-build-backend. #1502

Use rapids-build-backend. #1502

Conversation

bdice commented Mar 13, 2024 • edited by jameslamb Loading

Description

Checklist

jameslamb commented May 21, 2024

vyasr left a comment

Choose a reason for hiding this comment

vyasr left a comment

Choose a reason for hiding this comment

KyleFromNVIDIA commented May 23, 2024

jameslamb commented May 23, 2024

vyasr left a comment

Choose a reason for hiding this comment

jameslamb May 24, 2024

Choose a reason for hiding this comment

jameslamb commented May 24, 2024

jameslamb commented May 24, 2024

trivialfis commented Jul 12, 2024

jakirkham commented Jul 12, 2024

trivialfis commented Jul 13, 2024

bdice commented Mar 13, 2024 •

edited by jameslamb

Loading