-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test updates of CCCL (thrust, cub, libcudacxx) to 2.1.0. #1247
Conversation
@robertmaynard @vyasr Thrust added a dependency on libcudacxx in version 2.0.0. That means we get different behavior than I had hoped for with rapidsai/rapids-cmake#399. Specifically, Thrust is pulling in libcudacxx version 1.8.1.0 from its git submodule dependency, while I would like to pin to the latest version 2.1.0. What would you recommend doing here? Do we need to add a CMake requirement for libcudacxx before Thrust finds its own outdated submodule copy? Before (Thrust 1.17.2):
After (Thrust 2.1.0):
|
We should update |
07e0d6e
to
8d4031e
Compare
@robertmaynard I have now updated libcudacxx upstream and it appears that builds/tests are passing. I verified in the logs that Thrust/CUB/libcudacxx versions 2.1.0 are being used. I will open testing PRs for other RAPIDS repositories. |
Note to self: switch rmm to use fetch_rapids.cmake. That way, the logic for rapids-cmake won’t be duplicated between the C++ and Python CMakeLists.txt. https://github.com/rapidsai/cudf/blob/branch-23.10/fetch_rapids.cmake edit: done in #1319. |
This PR migrates RMM to use `fetch_rapids.cmake` like most RAPIDS repos. This makes it easier to define a single source if the upstream branch of rapids-cmake needs to change for testing, like in #1247. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Robert Maynard (https://github.com/robertmaynard) URL: #1319
889f14a
to
5151162
Compare
Closing in favor of #1404. |
This PR updates RMM to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update. Depends on rapidsai/rapids-cmake#495. Replaces #1247. Authors: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1404
This PR tests a rapids-cmake branch with CCCL (thrust, cub, libcudacxx) updated to 2.1.0. Do not merge this PR. The changes will be merged upstream in rapids-cmake after all libraries pass CI.