Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-cmake 22.10 best practice for RAPIDS.cmake location #1083

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Use rapids-cmake 22.10 best practice for RAPIDS.cmake location #1083

merged 2 commits into from
Aug 9, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard
Use rapids-cmake 22.10 best practice for RAPIDS.cmake location
c503435 
Removes possiblity of another projects RAPIDS.cmake being used, and removes need to always download a version.
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change labels Aug 8, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner August 8, 2022 17:43
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 457ece7 into rapidsai:branch-22.10 Aug 9, 2022
@robertmaynard robertmaynard deleted the place_rapids.cmake_in_current_bin_dir branch August 9, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working CMake non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @harrism @bdice