Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deprecations warnings should be errors #1727

Closed
harrism opened this issue Nov 13, 2024 · 0 comments · Fixed by #1728
Closed

[BUG] Deprecations warnings should be errors #1727

harrism opened this issue Nov 13, 2024 · 0 comments · Fixed by #1728
Assignees
Labels
bug Something isn't working CMake cpp Pertains to C++ code

Comments

@harrism
Copy link
Member

harrism commented Nov 13, 2024

Describe the bug
RMM test and benchmark CMakeLists.txt disable warnings as errors for deprecated declarations by specifying -Wno-error=deprecated-declarations. Currently we have direct usage of deprecated rmm::logger()in the replay benchmarkreplay.cpp` which results in warnings, but no errors.

See also rapidsai/build-planning#26

Steps/Code to reproduce bug
Build with -DBUILD_BENCHMARKS=ON

Expected behavior
All warnings should be treated as errors and there should be no warnings.

Environment details (please complete the following information):

  • Environment location: [Docker]
  • Method of RMM install: [from source]
    • If method of install is [Docker]: RAPIDS combined dev container
@harrism harrism added bug Something isn't working CMake cpp Pertains to C++ code labels Nov 13, 2024
@harrism harrism self-assigned this Nov 13, 2024
@harrism harrism changed the title [BUG] Deprecations warnings should not be ignored [BUG] Deprecations warnings should be errors Nov 13, 2024
@harrism harrism moved this from Todo to Review in RMM Project Board Nov 13, 2024
@rapids-bot rapids-bot bot closed this as completed in 220003e Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake cpp Pertains to C++ code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant