Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite rmm::device_scalar to take a cuda::mr::async_resource_ref instead of a device_memory_resource* #1446

Closed
Tracked by #1445
miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1447
Closed
Tracked by #1445

Rewrite rmm::device_scalar to take a cuda::mr::async_resource_ref instead of a device_memory_resource* #1446

miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1447
Assignees
@miscco
Labels
feature request New feature or request

Comments

@miscco
Copy link
Contributor

miscco commented Jan 30, 2024

No description provided.

This was referenced Jan 30, 2024
Open
Merged
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Move device_scalar over to async_resource_ref
6288b8c 
Addresses rapidsai#1446
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Move rmm::device_scalar over to cuda::mr::async_resource_ref
1db2eae 
This rewrites `rmm::device_scalar` to take a `cuda::mr::async_resource_ref` instead of a plain `rmm::device_memory_resource*`.

This is completely opaque to the user as the underlying `rmm::device_uvector` already takes a `cuda::mr::async_resource_ref`

Addresses rapidsai#1446
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Move rmm::device_scalar over to cuda::mr::async_resource_ref
c7288cb 
This rewrites `rmm::device_scalar` to take a `cuda::mr::async_resource_ref` instead of a plain `rmm::device_memory_resource*`.

This is completely opaque to the user as the underlying `rmm::device_uvector` already takes a `cuda::mr::async_resource_ref`

Addresses rapidsai#1446
@harrism harrism added the feature request New feature or request label Jan 30, 2024
@harrism harrism moved this from Todo to Review in RMM Project Board Jan 30, 2024
@rapids-bot rapids-bot bot closed this as completed in #1447 Feb 2, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miscco miscco

Labels
feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change device_scalar to take async_resource_ref miscco/rmm
2 participants
@harrism @miscco