Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapids_cmake_install_lib_dir now aware of GNUInstallDirs improvements in CMake 3.22 #85

Conversation

robertmaynard
Copy link
Contributor

Starting with 3.22, CMake is fully aware of the conda 'lib' requirements so we don't need todo all the conda checks ourselves.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 2 - In Progress Currenty a work in progress labels Sep 17, 2021
@robertmaynard
Copy link
Contributor Author

rerun tests

1 similar comment
@robertmaynard
Copy link
Contributor Author

rerun tests

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Sep 24, 2021
@robertmaynard robertmaynard added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team labels Oct 8, 2021
@robertmaynard
Copy link
Contributor Author

Waiting on 3.22-rc1

@robertmaynard robertmaynard force-pushed the install_lib_dir-cmake-3.22-aware branch from 5ef48eb to e36f9c8 Compare October 19, 2021 14:09
@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Oct 19, 2021
@robertmaynard
Copy link
Contributor Author

Corrected test issue found by using CMake 3.22-rc1

@robertmaynard robertmaynard force-pushed the install_lib_dir-cmake-3.22-aware branch from e36f9c8 to 12c3900 Compare October 19, 2021 14:27
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 03a8349 into rapidsai:branch-21.12 Oct 19, 2021
@robertmaynard robertmaynard deleted the install_lib_dir-cmake-3.22-aware branch October 19, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant