Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuco git tag to fetch several bug fixes #412

Merged
merged 4 commits into from
May 12, 2023
Merged

Update cuco git tag to fetch several bug fixes #412

merged 4 commits into from
May 12, 2023

Conversation

PointKernel
Copy link
Member

Description

This is a follow-up PR of #407. It fetches the latest cuco that fixes several bugs uncovered during libcudf integration.

rapidsai/cudf#13343 verified this won't break cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

bdice
bdice approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, since CI passed in libcudf. Thanks for cross-linking that.

@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 12, 2023
@bdice
Copy link
Contributor

bdice commented May 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9dc2d58 into rapidsai:branch-23.06 May 12, 2023
@PointKernel PointKernel deleted the cuco-bug-fixes branch May 12, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @bdice