Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify rapids_cuda_init_architectures behavior #279

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Clarify rapids_cuda_init_architectures behavior #279

merged 2 commits into from
Oct 4, 2022

Conversation

robertmaynard
Copy link
Contributor

No description provided.

@robertmaynard robertmaynard added doc Documentation 3 - Ready for Review Ready for review by team labels Oct 4, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner October 4, 2022 13:42
bdice
bdice approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification. I have a couple minor suggestions.

rapids-cmake/cuda/init_architectures.cmake Outdated Show resolved Hide resolved
rapids-cmake/cuda/init_architectures.cmake Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

Good clarification. I have a couple minor suggestions.

Thanks for the grammar corrections, applied.

@robertmaynard robertmaynard added the non-breaking Introduces a non-breaking change label Oct 4, 2022
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b28e241 into rapidsai:branch-22.12 Oct 4, 2022
@robertmaynard robertmaynard deleted the docs/clarify_cuda_init_rules branch October 13, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice