Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create conda package of patched dependencies #275

Merged
merged 11 commits into from
Nov 4, 2022
Merged

Create conda package of patched dependencies #275

merged 11 commits into from
Nov 4, 2022

Conversation

robertmaynard
Copy link
Contributor

Instead of having the rapids version of thrust , cub, and libcudacxx being part of the librmm package provide them as a separate package.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Sep 21, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner September 21, 2022 20:25
@robertmaynard robertmaynard changed the base branch from branch-22.10 to branch-22.12 September 26, 2022 16:28
@robertmaynard robertmaynard mentioned this pull request Oct 4, 2022
Merged
@robertmaynard
Copy link
Contributor Author

@bdice I want to resume working on this for 22.12. Do you like the state of this PR?

My thinking is we would merge this, followed by #283 and than open a final PR for using the new github actions that will upload the conda package.

ajschmidt8
ajschmidt8 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to you guys for the final review / merge, but looks good from an Ops perspective.

bdice
bdice approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard This looks great to me. I also support your plan to merge this and then work through GitHub Actions / deployment.

bdice
bdice requested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Python dependency. See comment.

bdice
bdice approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to me. We'll iron out any remaining issues once nightlies are deployed.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a63989a into rapidsai:branch-22.12 Nov 4, 2022
@robertmaynard robertmaynard deleted the fea/conda-rapids-dep-package branch November 4, 2022 14:57
rapids-bot bot pushed a commit that referenced this pull request Nov 7, 2022
@robertmaynard
Add GitHub action workflow to rapids-cmake (#283)
dd21036 
Enable github actions for rapids-cmake

Requires #275

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @bdice @ajschmidt8