Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs now provide rapids_find_package examples #220

Merged

Conversation

robertmaynard
Copy link
Contributor

Added examples to the rapids_find_package to better show the requirements on argument passing.

@robertmaynard robertmaynard added doc Documentation 3 - Ready for Review Ready for review by team labels Jul 21, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner July 21, 2022 18:57
@robertmaynard robertmaynard added the non-breaking Introduces a non-breaking change label Jul 21, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and questions, generally looks good.

rapids-cmake/find/package.cmake Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
robertmaynard and others added 7 commits July 21, 2022 18:29
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, otherwise LGTM.

rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
rapids-cmake/find/package.cmake Outdated Show resolved Hide resolved
robertmaynard and others added 3 commits July 22, 2022 09:18
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f2c6292 into rapidsai:branch-22.08 Jul 22, 2022
@robertmaynard robertmaynard deleted the docs/expand_find_package_docs branch July 22, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants