Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update nvcomp to 2.3.2 (#209)" (#210)" #211

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 8, 2022

This reverts commit 7a5c429.

This should not be merged yet. I'm going to open a cudf PR against this to make sure everything works before we merge.

@vyasr vyasr added feature request New feature or request non-breaking Introduces a non-breaking change 2 - In Progress Currenty a work in progress labels Jul 8, 2022
@vyasr vyasr self-assigned this Jul 8, 2022
@vyasr vyasr requested a review from a team as a code owner July 8, 2022 17:25
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested in rapidsai/cudf#11227, and the previous problem with nvcomp was fixed in rapidsai/cudf#11213.

@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currenty a work in progress labels Jul 8, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Jul 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 744ea67 into rapidsai:branch-22.08 Jul 8, 2022
@vyasr vyasr deleted the reupdate_nvcomp branch July 8, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants