rapids_export now handles explicit version values of 0 correctly #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic didn't work as CMake evaluates `0` as FALSE when it comes to `if` statements, and therefore we didn't build the correct version strings when a value was just `0`.
robertmaynard
added
bug
|
@trxcllnt This should resolve the issue with cuspatial at GTest |
trxcllnt
approved these changes
Mar 23, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic didn't work as CMake evaluates
0as FALSE when it comes toifstatements, and therefore we didn'tbuild the correct version strings when a value was just
0.