You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ARTIFACTS_URL=$(rapids-s3-path | sed "s|s3://${RAPIDS_DOWNLOADS_BUCKET}|https://${RAPIDS_DOWNLOADS_DOMAIN}|")
To prevent this manual replacement from being necessary, we should add a rapids-http-path script that computes the https://downloads.rapids.ai path.
The scripts should ultimately be refactored to work like this:
_rapids-path - a new script that's called by rapids-s3-path and rapids-http-path to generate the URI path. This script is prefixed with an underscore (_) to denote that it's not intended by be used publicly (only by other gha-tools scripts).
rapids-s3-path - should be refactored to call _rapids-path and prepend the s3://rapids-downloads/ string
rapids-http-path - a new script that calls _rapids-path and prepends the https://downloads.rapids.ai/ string
The text was updated successfully, but these errors were encountered:
rapids-s3-path is currently the source of truth for computing proper paths for CI workflow artifacts.
The problem with
rapids-s3-path
is that it only returns S3 URIs (e.g.s3://rapids-downloads/ci/cudf/...
).There are a lot of different areas where we call
rapids-s3-path
and then replaces3://rapids-downloads/
withhttps://downloads.rapids.ai/
:gha-tools/tools/_rapids-download-from-s3
Line 18 in 71f9e9a
gha-tools/tools/rapids-upload-to-s3
Line 36 in 71f9e9a
gha-tools/tools/rapids-upload-artifacts-dir
Line 32 in 71f9e9a
To prevent this manual replacement from being necessary, we should add a
rapids-http-path
script that computes thehttps://downloads.rapids.ai
path.The scripts should ultimately be refactored to work like this:
_rapids-path
- a new script that's called byrapids-s3-path
andrapids-http-path
to generate the URI path. This script is prefixed with an underscore (_
) to denote that it's not intended by be used publicly (only by othergha-tools
scripts).rapids-s3-path
- should be refactored to call_rapids-path
and prepend thes3://rapids-downloads/
stringrapids-http-path
- a new script that calls_rapids-path
and prepends thehttps://downloads.rapids.ai/
stringThe text was updated successfully, but these errors were encountered: