Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rapids-http-path script #65

Open
ajschmidt8 opened this issue Jul 24, 2023 · 1 comment
Open

Add rapids-http-path script #65

ajschmidt8 opened this issue Jul 24, 2023 · 1 comment
Assignees

Comments

@ajschmidt8
Copy link
Member

rapids-s3-path is currently the source of truth for computing proper paths for CI workflow artifacts.

The problem with rapids-s3-path is that it only returns S3 URIs (e.g. s3://rapids-downloads/ci/cudf/...).

There are a lot of different areas where we call rapids-s3-path and then replace s3://rapids-downloads/ with https://downloads.rapids.ai/:

To prevent this manual replacement from being necessary, we should add a rapids-http-path script that computes the https://downloads.rapids.ai path.

The scripts should ultimately be refactored to work like this:

  • _rapids-path - a new script that's called by rapids-s3-path and rapids-http-path to generate the URI path. This script is prefixed with an underscore (_) to denote that it's not intended by be used publicly (only by other gha-tools scripts).
  • rapids-s3-path - should be refactored to call _rapids-path and prepend the s3://rapids-downloads/ string
  • rapids-http-path - a new script that calls _rapids-path and prepends the https://downloads.rapids.ai/ string
@AyodeAwe AyodeAwe self-assigned this Aug 21, 2023
@AyodeAwe
Copy link
Contributor

Fixing in #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants