-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test_proxy.py::test_sizeof_cudf
#824
Comments
Yes, rapidsai/cudf#9544. cc @vyasr |
No, the one above has been taken care of via #767 . Notice how the build that's passing above is from January 6th and rapidsai/cudf#9544 was merged last November. It seems that the change affecting |
@madsbk it's not immediately clear whether there has been some change in cuDF that could have caused this. The closest candidate we have is rapidsai/rmm#931, but that was merged January 5th and my January 6th build was still passing, thus I think that's not it. Given the test is checking for approximate return values, any ideas whether this could have been a change from some other |
Closes #824 by increasing the tolerance of `sizeof` test of `cudf.DataFrame`. In the test we clear the `ProxyObject` cache, which makes `sizeof` measure the serialized dataframe. I order to avoid deserializing on every `sizeof` call, we accept this discrepancy between `sizeof` serialized and deserialized objects. Authors: - Mads R. B. Kristensen (https://github.com/madsbk) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) URL: #825
I'm seeing
dask_cuda/tests/test_proxy.py::test_sizeof_cudf
failing locally:The issue above is present with the following cuDF build:
But an old environment with the following passes:
@shwina @quasiben did we have any changes in cuDF that could have affected the way
sizeof
in any of its objects?cc @madsbk
The text was updated successfully, but these errors were encountered: