-
Notifications
You must be signed in to change notification settings - Fork 132
[FEA] pytorch polyphase resampler #491
Comments
Hey @mbolding3 -- love this work, and I'm excited to dive into your Pytorch compatible polyphase resampler over the next few days. Once reviewed, I'm thinking we add a new
I'd also not want to expose the Just kind of brainstorming here! CC @jfsantos, as we've chatted about this before. Would love your eyes on Mark's implementation. |
Thanks for the comments @awthomp ! I'll be trying to wrap up the unit tests and integration in the coming week. Will be in touch. |
@awthomp I'll have a look! Thanks a lot @mbolding3 for working on this. |
@jfsantos my pleasure! Currently writing a handful of unit tests. Will drop a line when the fork has something worth seeing. (Soon!) |
Install issues are slowing me down. Currently reinstalling Anaconda. |
Install issues resolved. Will be next week before substantive changes are pushed to the repo. Thanks for your patience guys! |
Alright sorry for the delay. The code is in a state where it passes some minimal tests and is worth looking at @jfsantos |
This issue has been labeled |
Removing inactive tag; been a wild summer, and still need to prioritize testing this PR prior to merge! Thanks for the patience, @mbolding3! |
I'm really sorry it has taken so long, but just a heads up I'll be testing this sometime next week. My application requires the backward pass to be fast but I can at least see if it works for now. |
Thank you @jfsantos. I want the code to be performant. We'll make sure it works right first, then inject the nitrous later. |
This issue has been labeled |
Opening this issue to facilitate discussion. A Pytorch compatible wrapper around cusignal's polyphase resampler is here (WIP).
@awthomp Where is a good place to put the source? Currently putting it in branch 22.08 in a new sub-directory
python/cusignal/pytorch
but curious if a place already exists.Also the backward method works (passes gradcheck, uses cusignal correlate) but is not optimized. It can be re-implemented most likely as another
resample_poly
call (since it upscales and convolves). That is on the to-do list.The text was updated successfully, but these errors were encountered: