Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Provide stateless API functions for kNN #415

Closed
cjnolet opened this issue Apr 1, 2019 · 1 comment
Closed

[TASK] Provide stateless API functions for kNN #415

cjnolet opened this issue Apr 1, 2019 · 1 comment
Labels
0 - Backlog In queue waiting for assignment Algorithm API Change For tracking changes to algorithms that might effect the API good first issue Good for newcomers

Comments

@cjnolet
Copy link
Member

cjnolet commented Apr 1, 2019 •
edited
Loading

kNN was originally written as a stateful class because FAISS required the use of a "GpuResources" object that was allocated upon the creation of an index and couldn't be de-allocated until the index was done being used.

Now that we are performing kNN without having to do any copies at all, we no longer need to maintain any state in the c++ side aside from the cuML handle.
@cjnolet cjnolet added feature request New feature or request ? - Needs Triage Need team to review and classify 1 - On Deck To be worked on next Algorithm API Change For tracking changes to algorithms that might effect the API and removed ? - Needs Triage Need team to review and classify labels Apr 1, 2019
@dantegd dantegd removed the feature request New feature or request label Apr 1, 2019
@cjnolet
Copy link
Member Author

cjnolet commented Apr 9, 2019

Tagging #456 for reference of origin

@cjnolet cjnolet added 0 - Backlog In queue waiting for assignment and removed 1 - On Deck To be worked on next labels Apr 9, 2019
@cjnolet cjnolet changed the title [TASK] Remove kNN class & fit() function [TASK] Provide stateless API functions for kNN Apr 16, 2019
@cjnolet cjnolet added the good first issue Good for newcomers label Apr 16, 2019
@dantegd dantegd mentioned this issue May 31, 2019
Merged
@cjnolet cjnolet closed this as completed Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog In queue waiting for assignment Algorithm API Change For tracking changes to algorithms that might effect the API good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantegd @cjnolet