[REVIEW] BUG Enable all GPU archs for test builds #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are failing on P100 runs without it. Will investigate further post-release.
update mechanism for detecting we're on Pascal or earlier GPU
BradReesWork
approved these changes
Dec 9, 2020
seunghwak
approved these changes
Dec 9, 2020
rlratzel
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1304 +/- ##
============================================
Coverage 60.38% 60.38%
============================================
Files 67 67
Lines 3029 3029
============================================
Hits 1829 1829
Misses 1200 1200 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling (temporarily) all GPU archs for test builds due to failures on Pascal when only arch 60 is built. This results in longer build times, and the optimization of only building for the test arch should be re-enabled at a later time. This also includes a fix to the cupy/scipy test markers was made to eliminate pytest warnings about incorrect markers.
closes #1303