Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSets: Move out of Experimental #3359

Closed
Tracked by #3357
BradReesWork opened this issue Mar 23, 2023 · 2 comments
Closed
Tracked by #3357

DataSets: Move out of Experimental #3359

BradReesWork opened this issue Mar 23, 2023 · 2 comments
Assignees
Labels
feature request New feature or request
Milestone

Comments

@BradReesWork
Copy link
Member

BradReesWork commented Mar 23, 2023

Move the class out of experimental

@BradReesWork BradReesWork changed the title Move out of Experimental DataSets: Move out of Experimental Mar 23, 2023
@BradReesWork BradReesWork added the feature request New feature or request label Mar 23, 2023
@rlratzel
Copy link
Contributor

We also need to remember to use the "promoted" deprecation util so we don't break anyone currently using cugraph.experimental.datasets

@nv-rliu nv-rliu assigned nv-rliu and unassigned nv-rliu Jun 28, 2023
@nv-rliu nv-rliu self-assigned this Jul 18, 2023
@nv-rliu
Copy link
Contributor

nv-rliu commented Jul 21, 2023

PR #3680 addresses this issue.

Status update for promoting the Datasets API

  • Users can now import stable datasets objects from cugraph.datasets
  • Experimental warning wrappers have been added to the deprecated version of datasets
  • test_dataset.py will now verify that an experimental dataset object will raise a DeprecationWarning upon use
  • test_dataset.py also verifies that the Graph object has the same properties (vertices, edges) as the metadata file used to create it
  • The location of the dataset batches have been migrated from cugraph/experimental/datasets to cugraph/testing
  • Redundant and unnecessary batches have been removed or localized to specific unit tests
  • The remaining batches now use an improved naming scheme
  • cugraph doc-strings, notebooks, and unit tests have been updated to use stable Datasets
  • The URLs for the metadata (eg karate.yaml) now point to data files hosted in a permanent S3 location

@nv-rliu nv-rliu added this to the 23.08 milestone Jul 21, 2023
@nv-rliu nv-rliu closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants