Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Allow Calling Uniform Neighbor Sample on unweighted Graphs #2438

Closed
alexbarghi-nv opened this issue Jul 22, 2022 · 1 comment · Fixed by #2567
Closed

[FEA] Allow Calling Uniform Neighbor Sample on unweighted Graphs #2438

alexbarghi-nv opened this issue Jul 22, 2022 · 1 comment · Fixed by #2567
Assignees
@alexbarghi-nv
Milestone
22.10

Comments

@alexbarghi-nv
Copy link
Member

Currently, uniform neighbor sampling requires that the graph be weighted, even though the intended behavior is to assume all weights are 1.0 if the graph is unweighted. This is a very simple one-line fix but there should be an additional test as well.
@alexbarghi-nv alexbarghi-nv added the ? - Needs Triage Need team to review and classify label Jul 22, 2022
@alexbarghi-nv alexbarghi-nv self-assigned this Jul 22, 2022
@alexbarghi-nv alexbarghi-nv added this to the 22.10 milestone Jul 22, 2022
@alexbarghi-nv alexbarghi-nv removed the ? - Needs Triage Need team to review and classify label Jul 22, 2022
@alexbarghi-nv alexbarghi-nv changed the title [BUG] Allow Calling Uniform Neighbor Sample on unweighted Graphs [IMP] Allow Calling Uniform Neighbor Sample on unweighted Graphs Jul 22, 2022
@alexbarghi-nv alexbarghi-nv changed the title [IMP] Allow Calling Uniform Neighbor Sample on unweighted Graphs [FEA] Allow Calling Uniform Neighbor Sample on unweighted Graphs Jul 22, 2022
@alexbarghi-nv alexbarghi-nv mentioned this issue Aug 17, 2022
Merged
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@rapids-bot rapids-bot bot closed this as completed in 1dc77bb Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
None yet
Projects
None yet
Milestone
22.10
Development

Successfully merging a pull request may close this issue.

CuGraph+PyG Wrappers and Loaders alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv