-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add dictionary support to cudf::quantile #6676
[REVIEW] Add dictionary support to cudf::quantile #6676
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6676 +/- ##
===============================================
+ Coverage 82.21% 82.27% +0.06%
===============================================
Files 94 94
Lines 15478 15539 +61
===============================================
+ Hits 12725 12785 +60
- Misses 2753 2754 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… dictionary-quantile
Reference #5963
Add support for dictionary column types in
cudf::quantile
. This function is also used bycudf::reduce
in PR #6666.The code change here is simply to dispatch on the dictionary key type and then pass a dictionary-iterator to transform function that computes the quantile values --
select_quantile_data
.This means this PR is also dependent on #6651 for the
is_dictionary
trait.Also, added a simple gtest for testing this new dictionary code path.