-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add dictionary support to cudf::clamp #6373
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #6373 +/- ##
===============================================
+ Coverage 82.82% 83.15% +0.33%
===============================================
Files 94 94
Lines 14432 14779 +347
===============================================
+ Hits 11953 12290 +337
- Misses 2479 2489 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just DRYing
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question on dispatch_clamp
null handling.
Reference #5963
Add specialization logic for dictionary type to the
cudf::clamp
API.This required introducing a
cudf::dictionary::detail::get_insert_index
function to retrieve an appropriate scalar index from an input scalar key value.This PR includes gtests for both the dictionary specialization and the
new get_insert_index
function.