Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add dictionary support to cudf::find_and_replace #6369

Merged
merged 5 commits into from
Oct 1, 2020

Conversation

davidwendt
Copy link
Contributor

Reference #5963

This PR adds dictionary support to the cudf::find_and_replace API.
All three input columns must be dictionary columns with matching key types.
Once the keys are merged, the find_and_replace is run against the indices.

gtests are added to the existing replace/replace_tests.cpp

@davidwendt davidwendt requested a review from a team as a code owner September 30, 2020 14:13
@davidwendt davidwendt self-assigned this Sep 30, 2020
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. labels Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #6369 into branch-0.16 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #6369      +/-   ##
===============================================
+ Coverage        83.16%   83.19%   +0.03%     
===============================================
  Files               94       94              
  Lines            14775    14802      +27     
===============================================
+ Hits             12287    12314      +27     
  Misses            2488     2488              
Impacted Files Coverage Δ
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c606f5c...44267b1. Read the comment docs.

@davidwendt davidwendt merged commit fb6c6de into rapidsai:branch-0.16 Oct 1, 2020
@davidwendt davidwendt deleted the dictionary-replace branch October 1, 2020 21:09
cwharris pushed a commit to cwharris/cudf that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants