Add lead and lag to java [skip ci] #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation for LEAD/LAG window functions, for fixed-width types. This version is implemented within grouped_rolling_window().
…f into jni_lead_lag
…f into jni_lead_lag
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
1. Fixed includes 2. Un-templatized DeviceLeadLag 3. Documentation fixes
…f into jni_lead_lag
1. Added test with default column with null values. 2. Variables for window bounds.
1. Moved Lead/Lag specific error checks out of rolling_window() 2. Moved Lead/Lag specific short-circuit evaluation out of rolling_window() 3. Added tests for error-checking
|
@mythrocks I upmerged. Will do it again once your PR goes in. @jlowe I would appreciate a review of the java/JNI code early so we can merge this in ASAP after the dependency is merged in. |
jlowe
reviewed
Oct 7, 2020
1. Remove redundant checks for LEAD/LAG in non-LEAD/LAG SFINAE path 2. Remove hardcode for stream id
jlowe
approved these changes
Oct 7, 2020
revans2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #6277 and will stay a WIP until it is merged in.
This adds in java APIs for the lead and lag functionality done as a part of the PR.