[REVIEW] Port scatter to tables to libcudf++ #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.11 #3448 +/- ##
============================================
Coverage 87.35% 87.35%
============================================
Files 49 49
Lines 9329 9329
============================================
Hits 8149 8149
Misses 1180 1180Continue to review full report at Codecov.
|
harrism
requested changes
Nov 24, 2019
| cudaStream_t stream = 0); | ||
|
|
||
| /** | ||
| * @brief Scatters the rows of a table to `n` tables according to a partition map |
There was a problem hiding this comment.
Not necessarily for this PR, but I think we should find a way to not have to maintain two copies of the docs which can diverge (detail and non-detail APIs).
There was a problem hiding this comment.
I think http://www.doxygen.nl/manual/commands.html#cmdcopydoc might be helpful
raydouglass
approved these changes
Nov 26, 2019
1 task
harrism
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left out of PR #3354
Needed for PR #3144