Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update gather_bitmask_kernel to use or remove unused template parameter #3444

Conversation

cwharris
Copy link
Contributor

gather_bitmask_kernel isn't using its ignore_out_of_bounds type argument. Removing it.

@cwharris cwharris requested a review from a team as a code owner November 22, 2019 21:43
@cwharris cwharris requested a review from shwina November 22, 2019 21:43
@cwharris cwharris self-assigned this Nov 22, 2019
@jrhemstad
Copy link
Contributor

If it's not being used, then that sounds like a bug that should be fixed, not removed.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #3444 into branch-0.11 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.11    #3444   +/-   ##
============================================
  Coverage        87.36%   87.36%           
============================================
  Files               49       49           
  Lines             9295     9295           
============================================
  Hits              8121     8121           
  Misses            1174     1174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfcbce...5dc428a. Read the comment docs.

@cwharris
Copy link
Contributor Author

I'll try to prove/disprove a bug exists for this, and go from there.

@cwharris cwharris changed the title remove unused template parameter from gather_bitmask_kernel [WIP] update gather_bitmask_kernel to use or remove unused template parameter Nov 23, 2019
@jrhemstad
Copy link
Contributor

You can see how it was used in the old gather_bitmask_kernel https://github.com/rapidsai/cudf/blob/branch-0.11/cpp/src/copying/legacy/gather.cuh#L83

@cwharris
Copy link
Contributor Author

This is closed by #3354.

@cwharris cwharris closed this Nov 26, 2019
@cwharris cwharris deleted the cudf-refactor-gather-bitmask-kernel branch December 21, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants