Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNI bindings for distinct_hash_join #15019

Merged
merged 9 commits into from
Feb 28, 2024
Merged

JNI bindings for distinct_hash_join #15019

merged 9 commits into from
Feb 28, 2024

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 9, 2024 •
edited
Loading

Description

Adds Java bindings to the distinct hash join functionality added in #14990.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jlowe jlowe added Performance Performance related issue Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2024
@jlowe jlowe self-assigned this Feb 9, 2024
@jlowe jlowe changed the title JNI bindings for unique_hash_join JNI bindings for distinct_hash_join Feb 14, 2024
@jlowe jlowe marked this pull request as ready for review February 23, 2024 21:45
@jlowe jlowe requested a review from a team as a code owner February 23, 2024 21:45
@vyasr vyasr removed the cuDF (Java) label Feb 23, 2024
jbrennan333
jbrennan333 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (other than minor checkstyle issues).

@jlowe jlowe mentioned this pull request Feb 26, 2024
Merged
@jlowe
Copy link
Member Author

jlowe commented Feb 27, 2024

/merge

@raydouglass
Copy link
Member

Admin merging while Python 3.11 is sorted out.

@raydouglass raydouglass merged commit 990ef0f into rapidsai:branch-24.04 Feb 28, 2024
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrennan333 jbrennan333 jbrennan333 approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@jlowe jlowe

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Performance Performance related issue Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlowe @raydouglass @ttnghia @jbrennan333 @vyasr