Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distinct key inner join #14990
Add distinct key inner join #14990
Changes from 51 commits
5676a7e
f732c9c
f08fbee
17dc00f
03f3bb7
3fe41ef
4667bfa
156a2d5
8526494
35f561c
4cd9a6c
cf99ef0
e893061
08eeecb
5aa1a97
83c3d2f
30a9dd1
a049b8e
c55c42b
9e3a708
0f2c854
c2d572d
f59234d
ce9b546
4c9a391
5e7f2a5
67c683b
b3cd8c7
a451cb4
1854315
ddd4eaf
5d6821f
a9c5529
41876be
c1b583f
52f8c7e
a218567
0ad3bdb
5a435af
cd9dca3
ee2844c
e210b9e
5bebd9e
51a8c26
40b4b4c
6cb38c7
cc5a88e
9b9600a
99b3255
2ee3c40
5aebff1
1ba7015
119a531
26f867a
876ed60
4201de6
e6c1271
de2a20d
ae5c73a
7864c3d
3e8b8fb
30724e9
6cc98f5
a56ff0c
715a101
73700d9
35253e8
35f2d9d
f6f66cf
800bee7
1259b2d
7a169e2
2c6b439
a801cd3
bc8ca49
ce7d8c0
505a6ab
4b376de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound extremely familiar to me 😛 . Can you extract the code into some common header (or
row_operators.cuh
) instead of putting here? We would probably reuse it somewhere else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such adapters look similar to each other while the contents are quite different, e.g. the insert comparator always returns false since we know all insert elements are distinct, the set key type is a pair of row hash value and row index which is rarely seen besides join operations, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this TODO need to be addressed in this PR or a later PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a separate PR. None of my current solutions is good enough thus need more time to think about this.